check size of cookie file #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation notes that the cookie file is always 32 bytes, and requires that any other size file not be used as an auth cookie. This is a very basic guard against tor asking for any file as a cookie. It's not sufficient to really secure the cookie auth method. This is a stopgap measure until SECURECOOKIE can be implemented.
|
I guess this solves the issue of #10 until the cookie auth method gets removed from tor eventually. |
|
This does not solve the issue at all. The user could have a 32 byte secret file and tor could still read it. This is only a quick patch that reduces the attack space significantly, it's not a fix. |
|
Yeah of course but better than nothing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation notes that the cookie file is always 32 bytes, and
requires that any other size file not be used as an auth cookie.
This is a very basic guard against tor asking for any file as a cookie.
It's not sufficient to really secure the cookie auth method. This is a
stopgap measure until SECURECOOKIE can be implemented.